This repository was archived by the owner on Jul 22, 2025. It is now read-only.
UX: Smoother streaming for discoveries #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help with smoother streaming, discovery preview will be shown/hidden via existing CSS only instead of JS too. The preview already contained the full update it was just being visually hidden so there should be no performance difference than before.
xfalcox
approved these changes
Feb 27, 2025
keegangeorge
added a commit
that referenced
this pull request
Feb 27, 2025
## 🔍 Overview This update ensures that the streaming for discoveries is smoother, especially on first update. ## ➕ More details To help with smoother streaming, the discovery preview (which was being tracked as a separate property in the JS logic) will be removed and the entire discovery content will be shown/hidden via the existing CSS. The preview was already receiving the full update even though it was visually hidden, so removing the separate property shouldn't have any negative performance hit. Visually hiding it with CSS only will help simplify the component and also allow for smoother streaming. We will instead remove the buffered streaming approach and instead use typing timers similar to what we did for streaming summarization. No related tests as streaming animations are difficult to test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
This update ensures that the streaming for discoveries is smoother, especially on first update.
➕ More details
To help with smoother streaming, the discovery preview (which was being tracked as a separate property in the JS logic) will be removed and the entire discovery content will be shown/hidden via the existing CSS. The preview was already receiving the full update even though it was visually hidden, so removing the separate property shouldn't have any negative performance hit. Visually hiding it with CSS only will help simplify the component and also allow for smoother streaming. We will instead remove the buffered streaming approach and instead use typing timers similar to what we did for streaming summarization.
No related tests as streaming animations are difficult to test.
📸 Screenshots
← Before
Screen.Recording.2025-02-26.at.18.40.34.mov
Screen.Recording.2025-02-26.at.18.41.09.mov
→ After
Screen.Recording.2025-02-26.at.18.37.44.mov
Screen.Recording.2025-02-26.at.18.37.00.mov